[libcxx-commits] [PATCH] D91574: [libc++] Simplify how we pick the typeinfo comparison

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/docs/BuildingLibcxx.rst:381
 
-.. option:: LIBCXX_TYPEINFO_COMPARISON_IMPLEMENTATION
-
----------------
smeenai wrote:
> Do you still wanna be removing this documentation?
That's a tough one. I kinda do.

I've been trying to avoid duplicate information in libc++, since that gets out of sync, etc. The set of options documented here does not reflect the real set of options provided in the CMake files, so I thought we might as well just have a single source of truth. For that reason, I tried to beef up the documentation of the option in `libcxx/CMakeLists.txt` itself.

Do you have an opinion about that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91574/new/

https://reviews.llvm.org/D91574