[libcxx-commits] [PATCH] D91565: Guard init_priority attribute within libc++

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 17 12:41:40 PST 2020


ldionne added inline comments.


================
Comment at: libcxx/include/__config:1444
+#else
+# define _LIBCPP_INIT_PRIORITY_MAX __attribute__((init_priority(101)))
+#endif
----------------
ldionne wrote:
> You should use `__has_attribute(init_priority)`.
Oh, and I would just define that in `iostream.cpp` if we don't use it anywhere else, to avoid adding complexity to `__config` (which is already a monster).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91565/new/

https://reviews.llvm.org/D91565



More information about the libcxx-commits mailing list