[libcxx-commits] [PATCH] D91586: Mark trivial_abi unique_ptr tests as unsupported in clang-11.

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 16 20:51:44 PST 2020


zoecarver created this revision.
zoecarver added a reviewer: ldionne.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.
zoecarver requested review of this revision.

It would appear that these tests fail for clang-11. See the CI <https://buildkite.com/llvm-project/libcxx-ci/builds/393#28cfac3a-5ca0-4eeb-8a46-da2315871dca> and Compiler Explorer <https://godbolt.org/z/Mc78cb>. This was exposed while testing D66262 <https://reviews.llvm.org/D66262>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91586

Files:
  libcxx/test/libcxx/memory/trivial_abi/unique_ptr_arg.pass.cpp
  libcxx/test/libcxx/memory/trivial_abi/unique_ptr_array.pass.cpp
  libcxx/test/libcxx/memory/trivial_abi/unique_ptr_destruction_order.pass.cpp
  libcxx/test/libcxx/memory/trivial_abi/unique_ptr_ret.pass.cpp


Index: libcxx/test/libcxx/memory/trivial_abi/unique_ptr_ret.pass.cpp
===================================================================
--- libcxx/test/libcxx/memory/trivial_abi/unique_ptr_ret.pass.cpp
+++ libcxx/test/libcxx/memory/trivial_abi/unique_ptr_ret.pass.cpp
@@ -13,7 +13,7 @@
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI
 
 // There were assertion failures in both parse and codegen, which are fixed in clang 11.
-// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10
+// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10, clang-11
 
 #include <memory>
 #include <cassert>
Index: libcxx/test/libcxx/memory/trivial_abi/unique_ptr_destruction_order.pass.cpp
===================================================================
--- libcxx/test/libcxx/memory/trivial_abi/unique_ptr_destruction_order.pass.cpp
+++ libcxx/test/libcxx/memory/trivial_abi/unique_ptr_destruction_order.pass.cpp
@@ -15,7 +15,7 @@
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI
 
 // There were assertion failures in both parse and codegen, which are fixed in clang 11.
-// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10
+// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10, clang-11
 
 #include <memory>
 #include <cassert>
Index: libcxx/test/libcxx/memory/trivial_abi/unique_ptr_array.pass.cpp
===================================================================
--- libcxx/test/libcxx/memory/trivial_abi/unique_ptr_array.pass.cpp
+++ libcxx/test/libcxx/memory/trivial_abi/unique_ptr_array.pass.cpp
@@ -13,7 +13,7 @@
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI
 
 // There were assertion failures in both parse and codegen, which are fixed in clang 11.
-// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10
+// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10, clang-11
 // UNSUPPORTED: c++03
 
 #include <memory>
Index: libcxx/test/libcxx/memory/trivial_abi/unique_ptr_arg.pass.cpp
===================================================================
--- libcxx/test/libcxx/memory/trivial_abi/unique_ptr_arg.pass.cpp
+++ libcxx/test/libcxx/memory/trivial_abi/unique_ptr_arg.pass.cpp
@@ -13,7 +13,7 @@
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_ABI_ENABLE_UNIQUE_PTR_TRIVIAL_ABI
 
 // There were assertion failures in both parse and codegen, which are fixed in clang 11.
-// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10
+// UNSUPPORTED: gcc, clang-4, clang-5, clang-6, clang-7, clang-8, clang-9, clang-10, clang-11
 
 #include <memory>
 #include <cassert>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91586.305650.patch
Type: text/x-patch
Size: 2747 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201117/3dca9d06/attachment-0001.bin>


More information about the libcxx-commits mailing list