[libcxx-commits] [PATCH] D91434: [libc++] Move the GDB pretty printer tests to the DSL

Mon Nov 16 08:01:07 PST 2020

ldionne added a comment.

In D91434#2394281 <https://reviews.llvm.org/D91434#2394281>, @saugustine wrote:

> The reason this hasn't been run by default is due to python versioning issues with gdb, the system it runs on, and the tests themselves. There are certain cross-platform issues as well.

We should strive to detect whether we can run the tests automatically instead, which is what this patch is trying to do. Otherwise, we just end up with code that is never run, which is bad because it eventually rots. What are the requirements of the GDB tests?

> What failures are you seeing?

I was seeing some failures locally in the CI Docker image, but I'm not seeing them anymore and the bots seem to be fine, so nevermind!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91434/new/

https://reviews.llvm.org/D91434