[libcxx-commits] [PATCH] D87171: Implement P0919R3

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D87171#2389858 <https://reviews.llvm.org/D87171#2389858>, @rarutyun wrote:

> I prepared the small change with adding the proper release version but I cannot upload the new diff. I guess that's because I am not author anymore @ldionne, is it possible to make me author again? I didn't find the way to do it myself, I guess I don't have permissions for that.

You should have been able to commandeer the revision again using the Phabricator UI. I don't think I have any special permission that allows me to do this but wouldn't let you.

In D87171#2387111 <https://reviews.llvm.org/D87171#2387111>, @rarutyun wrote:

> [...]
>
> - I don't understand why you changed `operator()` for `hash_impl` to take concrete types instead of `T&&`. If you think that it's better I don't my but I appreciate the explanation.

I used concrete types because I thought it made the code easier to read, and also it ensures that `hash` gets called with exactly these two types.

Since these changes are very simple, I just made them and I'll be committing this. I also fixed the GCC issue and verified it locally in a Docker image matching the CI bots.

Thanks for your contribution, and also thanks @Mordante for the find!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87171/new/

https://reviews.llvm.org/D87171