[libcxx-commits] [PATCH] D87171: Implement P0919R3

[Ruslan Arutyunyan via Phabricator via libcxx-commits]

rarutyun added a comment.



> I think this is pretty much good to go, however there's a specific way I'd like to structure the test harness to make the approach clearer. I'll commandeer this because it's a lot easier than explaining exactly what I mean, but LMK if you're OK with my approach. It's very very close to yours.

>From my perspective the recent changes use the very close approach. So I don't mind regarding to leave it as is.  I would like to add the few comments, but just for the information. I don't expect them to be applied

- I think that `LookupType` is better name than `SearchedType`. But I can live with that:)
- I don't mind with the `friend` approach. I did it myself but decided to change in the last moment.
- I don't understand why you changed `operator()` for `hash_impl` to take concrete types instead of `T&&`. If you think that it's better I don't my but I appreciate the explanation.

> If the update looks good to you, please provide the `Author Name <email at domain>` for the commit.

Yes, it looks good to me. `Ruslan Arutyunyan <ruslan.arutyunyan at intel.com>`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87171/new/

https://reviews.llvm.org/D87171