[libcxx-commits] [PATCH] D62760: allocate_shared should call allocator_traits::construct

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

Zoe and I discussed this offline, but saying here for watchers. I had to dive deep into this change because it is pretty complicated and I did not fully understand it. After playing around, I now understand why some things were done that way (e.g. why `aligned_storage` is being used) -- that is to avoid using `__compressed_pair`, which breaks the use case of private destructors.

However, I've come up with what I believe is a simpler approach to making this change in D91201 <https://reviews.llvm.org/D91201>. Zoe and I will be discussing that tomorrow, and we'll see what approach we end up taking (or perhaps a hybrid).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62760/new/

https://reviews.llvm.org/D62760