[libcxx-commits] [PATCH] D91139: [7/N] [libcxx] Don't use __int128 for msvc targets

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 10 08:58:59 PST 2020


mstorsjo added a subscriber: thakis.
mstorsjo added a comment.

In D91139#2386019 <https://reviews.llvm.org/D91139#2386019>, @ldionne wrote:

> This influences the ABI IIRC, so this choice may be forever.

Well afaik the ABI of libc++ on windows is rather non-fixed so far anyway

> Shouldn't we fix the compiler support lib on Windows instead?

The thing is, in setups when building with clang-cl, i.e. clang operating in MSVC mode, we only use the MSVC provided support libs, so there's not much we can fix ourselves there.

@rnk, @thakis, what do you guys think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91139/new/

https://reviews.llvm.org/D91139



More information about the libcxx-commits mailing list