[libcxx-commits] [PATCH] D65041: Change requirements on linear_congruential_engine

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM after fixing the nitpicks. For full disclosure, I'm relying on the tests a lot here because I am *not* a PRNG expert and I didn't take hours to research the algorithms in use. I'm trusting that you did look at other state of the art.



================
Comment at: libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/alg.pass.cpp:68
+
+  return 0;
+}
----------------
Inconsistent indentation here.


================
Comment at: libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/params.fail.cpp:17
+#include <random>
+#include <cassert>
+
----------------
Not needed.


================
Comment at: libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/params.fail.cpp:19
+
+#include "test_macros.h"
+
----------------
Not needed.


================
Comment at: libcxx/test/std/numerics/rand/rand.eng/rand.eng.lcong/params.fail.cpp:33
+
+  return 0;
+}
----------------
Same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65041/new/

https://reviews.llvm.org/D65041