[libcxx-commits] [PATCH] D90551: [libcxx] Implement P1956 rename low-level bit functions

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a subscriber: EricWF.
ldionne added a comment.

I would be tempted to rename the functions and just remove the old ones. It's not clear to me we're making anyone a flower by keeping the old ones but marking them as deprecated. I think we might just be introducing complexity and a migration burden for a non-existent problem.

The reason why I think the problem might be non-existent is that:

1. Those are not the most widely used functions
2. The old names never made it into any published C++ Standard, so we'd effectively be non-conforming by providing (deprecated) functions that don't exist in the standard
3. Many people compile with `-Werror`, so the difference between a deprecation warning and the name not being there is immaterial.

Can you please add a release note to `libcxx/docs/ReleaseNotes.rst`?

I'll launch a build at Apple to see whether removing the names causes issues. @EricWF  Can you please do the same at Google?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90551/new/

https://reviews.llvm.org/D90551