[libcxx-commits] [PATCH] D91154: [libc++] Guard __cpp_lib_constexpr_dynamic_alloc with compiler support

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 10 05:44:25 PST 2020


arichardson created this revision.
arichardson added reviewers: libc++, ldionne.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.
arichardson requested review of this revision.

This fix test failures in std/utilities/memory with Clang 8. Clang 8
supports the -std=c++2a flag, but does not implement
__cpp_constexpr_dynamic_alloc, so we get errors when evaluating some static
asserts in these test files.

I am not sure if the library version macro needs to depend on compiler
support, but some of the other macros already do this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91154

Files:
  libcxx/include/version
  libcxx/test/std/language.support/support.limits/support.limits.general/memory.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/version.version.pass.cpp
  libcxx/test/std/utilities/memory/allocator.traits/allocator.traits.members/allocate_hint.pass.cpp
  libcxx/test/std/utilities/memory/allocator.traits/allocator.traits.members/construct.pass.cpp
  libcxx/test/std/utilities/memory/allocator.traits/allocator.traits.members/destroy.pass.cpp
  libcxx/test/std/utilities/memory/default.allocator/allocator.members/allocate.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91154.304158.patch
Type: text/x-patch
Size: 5956 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201110/94b4eb58/attachment-0001.bin>


More information about the libcxx-commits mailing list