[libcxx-commits] [PATCH] D87940: [SystemZ][ZOS] Porting the time functions within libc++ to z/OS

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 10 04:46:22 PST 2020


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM except nitpick about header guard. Please rebase onto master, let CI run, and then we're good to go.



================
Comment at: libcxx/include/support/ibm/nanosleep.h:10
+
+#ifndef _LIBCPP_ZOS_NANOSLEEP
+#define _LIBCPP_ZOS_NANOSLEEP
----------------
The header include guard should be `_LIBCPP_SUPPORT_IBM_NANOSLEEP_H`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87940/new/

https://reviews.llvm.org/D87940



More information about the libcxx-commits mailing list