[libcxx-commits] [PATCH] D88818: [libc++][FreeBSD] XFAIL tests that need __atomic_* libcalls on older versions

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson planned changes to this revision.
arichardson added a comment.

Will update to use `non-lockfree-atomics`



================
Comment at: libcxx/utils/libcxx/test/features.py:122
+
+def _freebsdHasAtomicLibcalls(cfg):
+  freebsdVersion = int(compilerMacros(cfg, '-include sys/param.h').get('__FreeBSD_version', "0"))
----------------
ldionne wrote:
> This check shouldn't be FreeBSD specific. Instead, we should see whether we can reference these atomic operations generically, by checking the linker output of an appropriate program.
> 
> Also, can you explain why the `non-lockfree-atomics` feature doesn't do what you want?
I did not see the "non-lockfree-atomic" feature. That should do the same thing by checking whether the source compiles rather than doing it indirectly using a FreeBSD version check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88818/new/

https://reviews.llvm.org/D88818