[libcxx-commits] [PATCH] D91139: [7/N] [libcxx] Don't use __int128 for msvc targets

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added reviewers: libc++, rnk.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.
mstorsjo requested review of this revision.

While clang-cl can compile it just fine, the compiler support lib lacks support for it (as compiler-rt builtins aren't used).

This means that file_time_type has a shorter range on this target (+/- 292 years from the epoch). This is smaller than the range of the windows native file time type (which is 64 bit, with a 100 ns unit, from an epoch of year 1601), but covers the practically used range just fine. See docs/DesignDocs/FileTimeType.rst for more of the tradeoffs this means.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91139

Files:
  libcxx/include/__config


Index: libcxx/include/__config
===================================================================
--- libcxx/include/__config
+++ libcxx/include/__config
@@ -822,7 +822,7 @@
 typedef unsigned int   char32_t;
 #endif  // _LIBCPP_HAS_NO_UNICODE_CHARS
 
-#ifndef __SIZEOF_INT128__
+#if !defined(__SIZEOF_INT128__) || defined(_MSC_VER)
 #define _LIBCPP_HAS_NO_INT128
 #endif
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91139.304092.patch
Type: text/x-patch
Size: 374 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201110/d023d87f/attachment.bin>