[libcxx-commits] [PATCH] D91071: [libcxx] [test] Make a separate create_directory_symlink helper. NFC.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

LGTM!



================
Comment at: libcxx/test/support/filesystem_test_helper.h:347
         env_.create_file("non_empty_file", 42);
-        env_.create_symlink("dir1", "symlink_to_dir", false, true);
+        env_.create_directory_symlink("dir1", "symlink_to_dir", false);
         env_.create_symlink("empty_file", "symlink_to_empty_file", false);
----------------
mstorsjo wrote:
> ldionne wrote:
> > Why do we not sanitize the source here?
> Sanitizing the path here converts it into an absolute one, while I guess it's intentional to keep the symlinks relative.
Right, of course.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91071/new/

https://reviews.llvm.org/D91071