[libcxx-commits] [PATCH] D91071: [libcxx] [test] Make a separate create_directory_symlink helper. NFC.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 9 07:54:00 PST 2020


ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/support/filesystem_test_helper.h:347
         env_.create_file("non_empty_file", 42);
-        env_.create_symlink("dir1", "symlink_to_dir", false, true);
+        env_.create_directory_symlink("dir1", "symlink_to_dir", false);
         env_.create_symlink("empty_file", "symlink_to_empty_file", false);
----------------
Why do we not sanitize the source here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91071/new/

https://reviews.llvm.org/D91071



More information about the libcxx-commits mailing list