[libcxx-commits] [PATCH] D91004: [libc++] Implements concept destructible
Christopher Di Bella via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Nov 8 08:52:21 PST 2020
cjdb added inline comments.
================
Comment at: libcxx/test/std/concepts/concept.destructible/destructible.pass.cpp:56
+ static_assert( std::destructible<NoexceptDependant<int>>);
+ static_assert(!std::destructible<NoexceptDependant<double>>);
+}
----------------
@CaseyCarter had this to say back in D74291.
> There's tons of coverage here for class types and reference types. What about `void`, function types, pointers, arrays, pointers-to-members? (I don't know about clang/libc++, but the MSVC STL tests for type traits tend to _be_ the tests for compiler intrinsics used to implement those traits, so we consequently cover everything under the sun.)
I'd suggest we apply this here as well.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91004/new/
https://reviews.llvm.org/D91004
More information about the libcxx-commits
mailing list