[libcxx-commits] [PATCH] D91004: [libc++] Implements concept destructible

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 3 inline comments as done.
Mordante added a comment.

In D91004#2381027 <https://reviews.llvm.org/D91004#2381027>, @miscco wrote:

> LGTM

Thanks for the review!

> If there is another earnest push for concepts / ranges we should get together with @cjdb, @ldionne to see whether we find a way to not step on our toes and duplicate work.

Well I'd love to get ranges available in libc++, so I'm quite motivated to work on them. Of course it would be great if others want to join the effort since it's not a small feature. @cjdb, @ldionne are you currently working on concepts/ranges or willing to join the effort?



================
Comment at: libcxx/test/std/concepts/concept.destructible/destructible.pass.cpp:41
+constexpr bool test() {
+    assert( std::destructible<Empty>);
+
----------------
miscco wrote:
> I believe these should all be static_asserts and we should not need to have a "runtime" check of the trait
I just verified with the type_traits and they only use `static_asserts`, so I agree we should do the same with concepts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91004/new/

https://reviews.llvm.org/D91004