[libcxx-commits] [libcxx] bbd1506 - [libc++] Remove test that is irrelevant since f1a96de1bc8d

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2020-11-04T08:47:48-05:00
New Revision: bbd15062d2e15b7d3426327c5f7d506e016e9c0c

URL: https://github.com/llvm/llvm-project/commit/bbd15062d2e15b7d3426327c5f7d506e016e9c0c
DIFF: https://github.com/llvm/llvm-project/commit/bbd15062d2e15b7d3426327c5f7d506e016e9c0c.diff

LOG: [libc++] Remove test that is irrelevant since f1a96de1bc8d

We don't want to give the impression that we allow running arbitrary
shell commands under %{exec}, which isn't the case.

Added: 
    libcxx/test/libcxx/selftest/shell-no-escape-builtins.sh.cpp

Modified: 
    

Removed: 
    libcxx/test/libcxx/selftest/shell-escape.sh.cpp


################################################################################
diff  --git a/libcxx/test/libcxx/selftest/shell-escape.sh.cpp b/libcxx/test/libcxx/selftest/shell-no-escape-builtins.sh.cpp
similarity index 60%
rename from libcxx/test/libcxx/selftest/shell-escape.sh.cpp
rename to libcxx/test/libcxx/selftest/shell-no-escape-builtins.sh.cpp
index c942df0133b4..9f129d5703bf 100644
--- a/libcxx/test/libcxx/selftest/shell-escape.sh.cpp
+++ b/libcxx/test/libcxx/selftest/shell-no-escape-builtins.sh.cpp
@@ -6,13 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 
-// Make sure that arguments of the %{exec} substitution are shell-escaped
-// properly. If that wasn't the case, the command would fail because the
-// shell would look for a matching `"`.
-
-// RUN: %{exec} echo '"'
-
-// Also make sure that we don't escape Shell builtins like `!`, because the
+// Make sure that we don't escape Shell builtins like `!`, because the
 // shell otherwise thinks it's a command and it can't find it.
 
 // RUN: ! false