[libcxx-commits] [PATCH] D65041: Change requirements on linear_congruential_engine

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Nov 3 12:42:47 PST 2020


zoecarver marked an inline comment as done.
zoecarver added inline comments.


================
Comment at: libcxx/include/random:1677
+{
+    static_assert(__a != 0 || __m != 0 ||
+                  !_MightOverflow ||
----------------
ldionne wrote:
> zoecarver wrote:
> > This `static_assert` is redundant. Maybe I should remove it. 
> Can this be simplified to `static_assert(!_MightOverflow || _OverflowOK || _ShrageOk, "");`?
Yep :) Thanks.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65041/new/

https://reviews.llvm.org/D65041



More information about the libcxx-commits mailing list