[libcxx-commits] [PATCH] D69553: [libcxx] Error out if __libcpp_mbsrtowcs_l fails to convert anything in __time_get_storage

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

To test the issue itself, you'd need a platform with broken locale functions, and the issue is triggered by a number of the existing testcases.

The locale functions were broken in such a way on windows, triggering this issue, prior to D69505 <https://reviews.llvm.org/D69505> - and that patch fixed around 11 of the previously broken tests.

Before the patch that fixed the windows issue, the symptom of the problem was libc++ getting stuck in infinite loops; with this patch it would error out much more cleanly, which would have made it a bit easier to locate the root cause behind D69505 <https://reviews.llvm.org/D69505>.

So this patch doesn't fix any issue, it just changes a bad failure case (infinite loop) into a more manageable one (throwing an error).


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69553/new/

https://reviews.llvm.org/D69553