[libcxx-commits] [PATCH] D90072: [libc++] Add a libc++ configuration that does not support localization

Tue Nov 3 02:13:06 PST 2020

xiaoxiang781216 added inline comments.

================
Comment at: libcxx/test/libcxx/double_include.sh.cpp:152
+#   include <streambuf>
+#   include <strstream>
+#   if __cplusplus >= 201103L
----------------
ldionne wrote:
> xiaoxiang781216 wrote:
> > I would expect all stream/regex still support. only the encoding/format conversion or wide char version has to be skipped.
> Good luck pulling those out of the library. If you're willing to spend the time and make that work, I'll be more than happy to expand the no-localization mode to include some of `<iostream>`. Just make sure it doesn't become too complex.
> 
> Also note that this is primarily aimed at people doing embedded development. I would expect most of them probably don't care about `<iostream>` at all.
Ok, it's fine to disable the whole iostream/regex in the initial patch, we can do more fine tune in the furture.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90072/new/

https://reviews.llvm.org/D90072