[libcxx-commits] [PATCH] D80899: [libcxx] adds std::compare_three_way

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco added inline comments.


================
Comment at: libcxx/include/functional:515
 
+#if !defined(_LIBCPP_HAS_NO_SPACESHIP_OPERATOR)
+#include <compare>
----------------
Usually this is spellec as `#ifndef _LIBCPP_HAS_NO_SPACESHIP_OPERATOR`


================
Comment at: libcxx/include/functional:833
+      //requires three_way_comparable_with<_T1, _T2> || BUILTIN-PTR-THREE-WAY(_T1, _T2)
+      // TODO(cjdb): uncomment once three_way_comparable_with is commit
+    constexpr auto operator()(_T1&& __t, _T2&& __u) const
----------------
I had to read it twice o could we improve that comment to:
`// TODO(cjdb): Needs concept three_way_comparable_with`


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80899/new/

https://reviews.llvm.org/D80899