[libcxx-commits] [PATCH] D80821: [libc++] Fix issues with the triviality of std::array

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked 4 inline comments as done.
ldionne added inline comments.


================
Comment at: libcxx/test/std/containers/sequences/array/array.cons/implicit_copy.pass.cpp:75
+    {
+        typedef std::array<NoDefault, 0> Array;
+        Array array = {};
----------------
EricWF wrote:
> These tests aren't changing in behavior, right? You've just re-formated and renamed them?
Yes, that is correct.


================
Comment at: libcxx/test/std/containers/sequences/array/array.data/data.pass.cpp:52
         T* p = c.data();
-        LIBCPP_ASSERT(p != nullptr);
+        (void)p;
     }
----------------
EricWF wrote:
> I'm OK changing this to `p == nullptr` if that's the behavior we all implement.
> 
Will do in a follow up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80821/new/

https://reviews.llvm.org/D80821