[libcxx-commits] [PATCH] D80790: [libc++] Remove redundant empty specialization in std::array

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/include/array:290
-    _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14
-    iterator end() _NOEXCEPT {return iterator(data());}
-    _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14
----------------
Careful -- the diff is a bit confusing since it aligns the old specialization of `std::array<T, 0>` with the new `std::array<T, N>` base template. That's why it seems like the old diff was incorrectly implemented as `iterator end() _NOEXCEPT {return iterator(data());}`, when it really was correctly implemented because that was for the empty-array case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80790/new/

https://reviews.llvm.org/D80790