[libcxx-commits] [PATCH] D80690: [RISCV] Support libunwind for riscv32

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D80690#2060681 <https://reviews.llvm.org/D80690#2060681>, @kamleshbhalui wrote:

> In D80690#2060505 <https://reviews.llvm.org/D80690#2060505>, @ldionne wrote:
>
> > @kamleshbhalui Just to be clear -- you need libunwind approval before you can submit a patch that touches libunwind. If you just wanted to iterate on this privately it's OK, but you'll need approval from the group before submitting.
>
>
> Thanks @ldionne , wasn't aware of this. added the group as reviewer.


That's the reason why `libunwind` is added as a blocking reviewer to reviews that touch libunwind. At least one maintainer (or person familiar with the code base) needs to give you a thumbs up.

Changes in these runtimes components have very wide impact, and unfortunately they're usually not very well tested. That's why we have these requirements.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80690/new/

https://reviews.llvm.org/D80690