[libcxx-commits] [PATCH] D78763: Add optimization to basic_string::assign for compile-time known constant values.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D78763#2057956 <https://reviews.llvm.org/D78763#2057956>, @mvels wrote:

> > Well, I think we should probably remove that notion, or merge it with the "unstable" ABI. It's not really a thing since V2 is basically unstable AFAICT.
> > 
> > Just fix it and we can improve the situation (i.e. probably remove it) later.
>
> I have no way to verify / test this (cross compiling apple darwin v2 looks to be impossible?), and guessing the mangled names from x86 compiles seems dubious as well given the diffs I see on apple v1 vs linux v1
>
> Shall I simply remove the x86_64-apple-darwin.v2.abilist insteasd? (I noticed these are simple 'check if present' targets)


Yeah, I guess that's fine. Nobody uses it anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78763/new/

https://reviews.llvm.org/D78763