[libcxx-commits] [PATCH] D80441: [libc++] Turn off formatting of files generated by generate_feature_test_macro_components.py. NFC

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D80441#2052038 <https://reviews.llvm.org/D80441#2052038>, @curdeius wrote:

> Ok, fair enough. I'll abandon this revision then.
>  Should we then update .clang-format (at least for the directory where auto-generated tests are) or update the python script so that it matches libc++ style?
>  For the former, `IndentPPDirectives` should be set to `AfterHash`.


Agreed.

> For clang-formatting libc++, are there any plans when it will be done? How may I help?

There are no set-in-stone plans, however I would welcome changes to the `.clang-format` that make it work for our usage, and then we could clang-format the whole code base (and add the commit to `.git-blame-ignore-revs`). So if you'd like to help, you could open a review that tweaks the `.clang-format` with what you think is necessary, and then we can iterate on that. I'll try clang-formatting everything just now to see how much of a mess it creates.

If we think we can move forward with clang-formatting everything, I can send a message to the list for discussion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80441/new/

https://reviews.llvm.org/D80441