[libcxx-commits] [PATCH] D72959: Relative VTables ABI on Fuchsia

John McCall via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 21 22:45:55 PDT 2020


rjmccall added a comment.

Otherwise LGTM.



================
Comment at: clang/lib/CodeGen/CGVTables.cpp:633
+  llvm::Module &module = CGM.getModule();
+  llvm::SmallString<16> componentName(globalVal->getName());
+
----------------
`componentName` seems to no longer be used meaningfully. in this function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72959/new/

https://reviews.llvm.org/D72959





More information about the libcxx-commits mailing list