[libcxx-commits] [PATCH] D78763: Add optimization to basic_string::assign for compile-time known constant values.

[Martijn Vels via Phabricator via libcxx-commits]

mvels added a comment.

In D78763#2001599 <https://reviews.llvm.org/D78763#2001599>, @ldionne wrote:

> Please make sure you update the ABI v2 abi list when you make these changes. It's currently broken (and this change will break it even more). You can run `make check-cxx-abilist` to see the failures.
>
> Or, I guess we can also have a discussion to disable the abi list tests for unstable ABIs, since it's not that useful I guess.


Thanks Luis, I noticed the ABI list checks are remove from unstable, thanks!

I will check with ericwf@ on further review, I scoped this change down to only the inlining part, optimizing capacity step ups and growth will follow in separate changes (our data indicates its a win)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78763/new/

https://reviews.llvm.org/D78763