[libcxx-commits] [PATCH] D78154: [WIP][libc++] Link c++experimental.a into libc++.dylib when enabled

[Louis Dionne via Phabricator via libcxx-commits]

ldionne abandoned this revision.
ldionne added a comment.

In D78154#1982221 <https://reviews.llvm.org/D78154#1982221>, @jwakely wrote:

> In D78154#1981905 <https://reviews.llvm.org/D78154#1981905>, @ldionne wrote:
>
> > @jwakely , how does libstdc++ ship experimental features? Does it ship them in its shared library?
>
>
> No. Everything is header-only, except the Filesystem TS stuff which is in a separate static lib (`libstdc++fs.a`) and not in the shared library. Generally we try to avoid adding things to the shared library until they are non-experimental (that wasn't the case in the past, and we have been burned by adding immature C++0x features to the shared library too soon).


Thanks for the input.

Revisiting this, I think it makes sense to have at least some explicit switch for enabling experimental features. I think the best would be a compiler flag that does whatever's required -- something like `-fexperimental`, which would automatically add `-lc++experimental` (and possibly other necessary things). Abandoning this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78154/new/

https://reviews.llvm.org/D78154