[libcxx-commits] [PATCH] D62760: allocate_shared should call allocator_traits::construct

Zoe Carver via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 16 13:46:10 PDT 2020


zoecarver updated this revision to Diff 264452.
zoecarver marked an inline comment as done.
zoecarver added a comment.

- Don't call construct before C++20
- Remove static_assert


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62760/new/

https://reviews.llvm.org/D62760

Files:
  libcxx/include/memory
  libcxx/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_default_deleter.fail.cpp
  libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/allocate_shared.pass.cpp
  libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/allocate_shared_construct.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62760.264452.patch
Type: text/x-patch
Size: 12278 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200516/14d13636/attachment-0001.bin>


More information about the libcxx-commits mailing list