[libcxx-commits] [PATCH] D80030: [libc++][test] cleanup some small test issues

[Casey Carter via Phabricator via libcxx-commits]

CaseyCarter created this revision.
CaseyCarter added reviewers: ldionne, EricWF, mclow.lists.
Herald added subscribers: libcxx-commits, dexonsmith.
Herald added a project: libc++.
Herald added a reviewer: libc++.

- improve coverage in `span`'s "conversion from `std::array`" test, while eliminating MSVC diagnostics about `testConstructorArray<T>() && testConstructorArray<const T, T>()` being redundant when `T` is already `const`.

- Don't test use of `is_assignable` that triggers UB due to an insufficiently-complete type argument in `std::function`'s assignment operator test on non-libc++. (Honestly, my preference would be to remove this.)

- Don't test that `shared_ptr` initialization from an rvalue triggers the lvalue aliasing constructor on non-libc++; this is not the case for Standard Libraries that implement LWG-2996. (Ditto, I'd simply remove this but it's your library ;).)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80030

Files:
  libcxx/test/std/containers/views/span.cons/stdarray.pass.cpp
  libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/F_assign.pass.cpp
  libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/shared_ptr_pointer.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80030.264330.patch
Type: text/x-patch
Size: 4765 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200515/2c0b313d/attachment.bin>