[libcxx-commits] [PATCH] D56398: Add new EINTEGRITY errno

[Dimitry Andric via Phabricator via libcxx-commits]

dim added a comment.

In D56398#2038621 <https://reviews.llvm.org/D56398#2038621>, @ldionne wrote:

> Since we should pick up FreeBSD's `EINTEGRITY` via `include_next`, I don't see why we need this patch. Can we abandon?


I guess so. But maybe the whole `ELAST` logic could be ripped out, as it does not seem to serve any purpose anymore? The whole difficult `#ifdef` stuff is only to define some "really last" error number, and it's only used to define the `EOWNERDEAD` and `ENOTRECOVERABLE` values, which for some reason are 'special'. But just a few lines below, a bunch of `EXXX` values just get defined to self-chosen values...

Let's indeed abandon this, and I'll come up with a diff to get rid of this whole first block.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56398/new/

https://reviews.llvm.org/D56398