[libcxx-commits] [PATCH] D70346: [libc++] [LWG3321] Mark "year_month_day_last::day() specification does not cover !ok() values" issue as "Nothing to do", but add assertion.

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added a comment.

Well, I redefined `_NOEXCEPT` to nothing, but there are hacks involved.
First of all, libc++ headers include `<__config>` that defines `_NOEXCEPT` unconditionally. So I needed to make it conditional.
Secondly, to make this work I replaced `noexcept` with `_NOEXCEPT` on day() method in `<chrono>`.
And yeah, then I defined `_NOEXCEPT` to nothing, but it seems to me a dangerous endeavour.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70346/new/

https://reviews.llvm.org/D70346