[libcxx-commits] [PATCH] D79888: libc++: include unistd.h if available to get some preprocessor macros

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D79888#2034894 <https://reviews.llvm.org/D79888#2034894>, @LittleFox94 wrote:

> In D79888#2034859 <https://reviews.llvm.org/D79888#2034859>, @EricWF wrote:
>
> > We could lift the two macros that depend on `_NEWLIB_VERSION` into the headers that use them.
> >  Then we'll avoid the include in config.
>
>
> sounds good to me. If this is also good for @ldionne I'll prepare a new patch :)


Yeah, I'd like to see that patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79888/new/

https://reviews.llvm.org/D79888