[libcxx-commits] [PATCH] D79784: [libc++] Adjust how we guard the inclusion of unistd.h

[John Brawn via Phabricator via libcxx-commits]

john.brawn marked an inline comment as done.
john.brawn added inline comments.


================
Comment at: libcxx/include/__config:1556
+#if defined(__unix__) || (defined(__APPLE__) && defined(__MACH__)) || defined(__CloudABI__) || defined(__Fuchsia__) || defined(__wasi__)
+#define _LIBCPP_HAS_UNISTD
+#endif
----------------
ldionne wrote:
> Naive question: why not use `__has_include`?
Because I didn't know about it. Looks like all the compiler version we support (in llvm/cmake/modules/CheckCompilerVersion.cmake) implement it, so it makes sense to use it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79784/new/

https://reviews.llvm.org/D79784