[libcxx-commits] [PATCH] D74577: [libcxx][span] Implement P1976R2

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

We're almost there! When you run `generate_feature_test_macro_components.py`, it prints out something like `producing new <version> header as /var/folders/10/r6bw68bs5b9gwjtrnl9dz0vm0000gn/T/version.Xe5egJ` at the end. You must `mv /var/...../version.asdasd libcxx/include/version` to replace the current `<version>` header with that one. Otherwise the `__cpp_lib_span` macro won't be defined properly. Currently, this causes the tests to fail with this patch applied.

Also, please exclude changes to other tests like `execution.version.pass.cpp` from this patch -- I'll generate them separately, I think it's an oversight.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74577/new/

https://reviews.llvm.org/D74577