[libcxx-commits] [PATCH] D62928: Constrain function assignment operator (2574)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: broadwaylamb.
Herald added a reviewer: libc++.
This revision now requires review to proceed.

LGTM. It would be great if you could provide a patch that moves adding the reference outside of `__callable`, such that the code becomes: `_EnableIfCallable<typename decay<_Fp>::type&>` (notice the added reference here). You'd have to look at other usages of `_EnableIfCallable` too. Note that some usages of `_EnableIfCallable` correspond to places in the Standard where the term Lvalue-Callable is used. We could consider adding a `LValueCallable` trait to mirror that. Just a suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62928/new/

https://reviews.llvm.org/D62928