[libcxx-commits] [PATCH] D79784: [libc++] Adjust how we guard the inclusion of unistd.h

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/__config:1556
+#if defined(__unix__) || (defined(__APPLE__) && defined(__MACH__)) || defined(__CloudABI__) || defined(__Fuchsia__) || defined(__wasi__)
+#define _LIBCPP_HAS_UNISTD
+#endif
----------------
Naive question: why not use `__has_include`?


================
Comment at: libcxx/src/filesystem/operations.cpp:40
-#if !defined(_WIN32)
-#include <unistd.h>
-#endif
----------------
You're not including it anymore?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79784/new/

https://reviews.llvm.org/D79784