[libcxx-commits] [PATCH] D79406: [libcxx testing] Make three locking tests more reliable

Thu May 7 09:05:14 PDT 2020

ldionne accepted this revision.
ldionne added a comment.

In D79406#2024856 <https://reviews.llvm.org/D79406#2024856>, @davezarzycki wrote:

> Hi @ldionne – I've looked a few more tests that use lit's ALLOW_RETRIES feature. I don't think this is a straightforward scenario. While the flawed assumptions are often the same, the fixes are not. Do you want 46 Phab requests? Personally speaking, this seems like one of those cases where the cost of code review discourages bug fixes. If I create decent enough commit messages, would you be open to post-commit review for these test fixes? After all, the tests are already buggy, and we can always revert back to the known buggy version that we have today.

I'm entirely fine with that approach! Thanks a lot for taking a look.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79406/new/

https://reviews.llvm.org/D79406