[libcxx-commits] [PATCH] D79343: [libc++][test] Adjust move_iterator tests to allow C++20

[Casey Carter via Phabricator via libcxx-commits]

CaseyCarter marked 2 inline comments as done.
CaseyCarter added a comment.

Format issues addressed.



================
Comment at: libcxx/test/std/iterators/predef.iterators/move.iterators/move.iterator/types.pass.cpp:33
 struct DummyIt {
-  typedef std::forward_iterator_tag iterator_category;
-  typedef ValueType value_type;
-  typedef std::ptrdiff_t difference_type;
-  typedef ValueType* pointer;
-  typedef Reference reference;
+    typedef std::forward_iterator_tag iterator_category;
+    typedef ValueType value_type;
----------------
dexonsmith wrote:
> You seem to be changing from 2-space indent (the usual practice for LLVM) to 4-space indent here.  I don't know if that's intentional, but if it's the right thing to do please do so in a separate commit to avoid adding noise to this patch.
Intentional - 4-space is the predominant indent in this file - but misguided. Thank you for the rundown of general formatting policy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79343/new/

https://reviews.llvm.org/D79343