[libcxx-commits] [PATCH] D78200: [libc++] [test] Generate static_test_env on the fly

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

If we don't want the static env, we should remove it entirely.
Meaning, we should convert each of these tests to use `dynamic_test_env` and setup the required files like the remainder of the tests do.



================
Comment at: libcxx/test/support/filesystem_test_helper.h:306
+  fs::path OldCWD;
+  CWDGuard() : OldCWD(fs::current_path()) { }
+  ~CWDGuard() { fs::current_path(OldCWD); }
----------------
I'm not OK with changing the tests working directory during the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78200/new/

https://reviews.llvm.org/D78200