[libcxx-commits] [PATCH] D72640: [libcxx] Qualify make_pair in searcher implementations to prevent ADL

[Logan Smith via Phabricator via libcxx-commits]

logan-5 added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.nonmodifying/alg.search/search.pass.cpp:63
+    int x;
+    bool operator==(S other) const 
+    { 
----------------
EricWF wrote:
> Make this a non-member.
No problem, but curious about the reason.


================
Comment at: libcxx/test/std/algorithms/alg.nonmodifying/alg.search/search.pass.cpp:69
+template <class T, class U>
+void make_pair(T&&, U&&) {}
+} // namespace User
----------------
EricWF wrote:
> `= delete`
Also curious. This doesn't seem like it makes much of a difference, although I suppose `= delete` communicates better that we don't intend to call this in the tests anywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72640/new/

https://reviews.llvm.org/D72640