[libcxx-commits] [PATCH] D78931: [libunwind][RISCV] Track PC separately from RA

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 5 05:53:02 PDT 2020


arichardson added subscribers: bsdjhb, jrtc27.
arichardson added a comment.

In D78931#2019950 <https://reviews.llvm.org/D78931#2019950>, @lenary wrote:

> Tagging @arichardson for a review from the FreeBSD perspective.
>
> Thanks for the link to the GCC implementation, that's helpful.


This change seems fine to me.

For our CHERI-RISCV version of libunwind I was considering using the zero register slot for a new register that we add (DDC). However, we already have to increase the size of the cursor to store our larger capability registers so we can just add another field instead.
Tagging @bsdjhb and @jrtc27 in case they have further comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78931/new/

https://reviews.llvm.org/D78931





More information about the libcxx-commits mailing list