[libcxx-commits] [PATCH] D78200: [libc++] [test] Generate static_test_env on the fly

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb marked an inline comment as done.
broadwaylamb added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.current_path/current_path.pass.cpp:54
 {
-    const path new_path = StaticEnv::Dir;
+    CWDGuard guard;
+    static_test_env static_env;
----------------
ldionne wrote:
> Just to confirm, you add the guard here because we change the current directory, but the directory is then removed so the test would fail if we didn't go back to the previous cwd at the end?
This test wouldn't fail, but other tests would. Otherwise yes, exactly as you said.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78200/new/

https://reviews.llvm.org/D78200