[libcxx-commits] [libcxx] 94361dd - [libc++] Always enable local submodule visibility in the test suite

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2020-05-04T13:29:24-04:00
New Revision: 94361ddd93d5627fe321fa9956e8ef017a767ed6

URL: https://github.com/llvm/llvm-project/commit/94361ddd93d5627fe321fa9956e8ef017a767ed6
DIFF: https://github.com/llvm/llvm-project/commit/94361ddd93d5627fe321fa9956e8ef017a767ed6.diff

LOG: [libc++] Always enable local submodule visibility in the test suite

When building with modules, always enable local submodule visibility.
It used to be disabled on Apple platforms, but it seems like we want
to use the same flags on Apple and Linux now (see https://reviews.llvm.org/D74892).

Added: 
    

Modified: 
    libcxx/utils/libcxx/test/config.py

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/libcxx/test/config.py b/libcxx/utils/libcxx/test/config.py
index db640ab9ab8c..3e9cae4f8fba 100644
--- a/libcxx/utils/libcxx/test/config.py
+++ b/libcxx/utils/libcxx/test/config.py
@@ -858,9 +858,7 @@ def configure_coverage(self):
             self.cxx.compile_flags += ['-O0']
 
     def configure_modules(self):
-        modules_flags = ['-fmodules']
-        if not self.target_info.is_darwin():
-            modules_flags += ['-Xclang', '-fmodules-local-submodule-visibility']
+        modules_flags = ['-fmodules', '-Xclang', '-fmodules-local-submodule-visibility']
         supports_modules = self.cxx.hasCompileFlag(modules_flags)
         enable_modules = self.get_lit_bool('enable_modules', default=False,
                                                              env_var='LIBCXX_ENABLE_MODULES')