[libcxx-commits] [libcxx] b420a09 - [libc++] Re-enable some tests under ASAN and MSAN

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 1 11:04:03 PDT 2020


Author: Louis Dionne
Date: 2020-05-01T14:03:51-04:00
New Revision: b420a0995961abdde414afc231810ca7eaf3b54d

URL: https://github.com/llvm/llvm-project/commit/b420a0995961abdde414afc231810ca7eaf3b54d
DIFF: https://github.com/llvm/llvm-project/commit/b420a0995961abdde414afc231810ca7eaf3b54d.diff

LOG: [libc++] Re-enable some tests under ASAN and MSAN

The tests were disabled under ASAN/MSAN because old Clangs were very
slow to build the test cases. However, I checked with the Clang used
on our build bots and the tests are not slow to build anymore, so the
tests can be re-enabled.

Added: 
    

Modified: 
    libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp
    libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
    libcxx/test/std/re/re.traits/isctype.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp b/libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp
index e8084f8f76ab..474f9ce57187 100644
--- a/libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp
@@ -12,9 +12,6 @@
 
 // iter_type put(iter_type s, ios_base& iob, char_type fill, double v) const;
 
-// TODO(EricWF): This test takes 40+ minutes to build with Clang 3.8 under ASAN or MSAN.
-// UNSUPPORTED: asan, msan
-
 #include <locale>
 #include <ios>
 #include <cassert>

diff  --git a/libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp b/libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
index 16c7d61cc936..074027129274 100644
--- a/libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
@@ -12,9 +12,6 @@
 
 // iter_type put(iter_type s, ios_base& iob, char_type fill, long double v) const;
 
-// TODO(EricWF): This test takes 40+ minutes to build with Clang 3.8 under ASAN or MSAN.
-// UNSUPPORTED: asan, msan
-
 // TODO GLIBC uses a 
diff erent string for positive and negative NAN numbers.
 // XFAIL: linux-gnu
 

diff  --git a/libcxx/test/std/re/re.traits/isctype.pass.cpp b/libcxx/test/std/re/re.traits/isctype.pass.cpp
index 1eed193ae00f..8c0b07988d6e 100644
--- a/libcxx/test/std/re/re.traits/isctype.pass.cpp
+++ b/libcxx/test/std/re/re.traits/isctype.pass.cpp
@@ -12,9 +12,6 @@
 
 // bool isctype(charT c, char_class_type f) const;
 
-// TODO(EricWF): This test takes 40+ minutes to build with Clang 3.8 under ASAN or MSAN.
-// UNSUPPORTED: asan, msan
-
 
 #include <regex>
 #include <cassert>


        


More information about the libcxx-commits mailing list