[libcxx-commits] [PATCH] D77190: [libc++abi] Fix remote execution of .sh.cpp tests

[Sergej Jaskiewicz via Phabricator via libcxx-commits]

broadwaylamb marked 2 inline comments as done.
broadwaylamb added inline comments.


================
Comment at: libcxx/utils/ssh.py:73
     if exe:
-        exe = os.path.join(tmp, os.path.basename(exe))
+        exe = posixpath.join(tmp, os.path.basename(exe))
 
----------------
We're dealing with target-specific paths here. For now assume that the target uses POSIX paths.


================
Comment at: libcxxabi/test/incomplete_type.sh.cpp:25
 // RUN: %{cxx} %{flags} %{compile_flags} -c %s -o %t.two.o -DTU_ONE
-// RUN: %{cxx} %{flags} %t.one.o %t.two.o -lc++abi %{link_flags} -o %t.exe
-// RUN: %t.exe
+// RUN: %{cxx} %{flags} %t.one.o %t.two.o %{link_libcxxabi} %{link_flags} -o %t.exe
+// RUN: %{run}
----------------
We need this because if both static and shared libc++abi are present, the linker will prefer the shared one. And if we're running this test viaSSH, we want to link it statically.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77190/new/

https://reviews.llvm.org/D77190