[libcxx-commits] [libcxx] 34756a1 - [libc++] Execute tests using an external shell

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 31 08:32:03 PDT 2020


Author: Louis Dionne
Date: 2020-03-31T11:31:39-04:00
New Revision: 34756a1c709d1ef0292413cddaeeef8a21ed2124

URL: https://github.com/llvm/llvm-project/commit/34756a1c709d1ef0292413cddaeeef8a21ed2124
DIFF: https://github.com/llvm/llvm-project/commit/34756a1c709d1ef0292413cddaeeef8a21ed2124.diff

LOG: [libc++] Execute tests using an external shell

This makes it closer to how one would run the tests by hand, and it is
also closer to how the SSHExecutor runs the tests remotely. It also
allows using shell builtins in .sh.cpp tests when using %{exec}.

Added: 
    

Modified: 
    libcxx/utils/run.py

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/run.py b/libcxx/utils/run.py
index 3e9a4703c8c7..6a89a2b9388a 100644
--- a/libcxx/utils/run.py
+++ b/libcxx/utils/run.py
@@ -49,7 +49,7 @@ def main():
             exit(1)
 
     # Run the executable with the given environment in the given working directory
-    return subprocess.call(remaining, cwd=args.working_directory, env=env)
+    return subprocess.call(' '.join(remaining), cwd=args.working_directory, env=env, shell=True)
 
 if __name__ == '__main__':
     exit(main())


        


More information about the libcxx-commits mailing list